byte is a signed type in java, so we need to mask it with &0xFF #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for more details, see
http://stackoverflow.com/questions/11380062/what-does-value-0xff-do-in-java
pretty weird, that such a "bug" is still existing
the "int read()" method of NetInputStreamUDT should not return a negative value, since it is interpreted as an EOF
the java byte type can have values from -128 .. +127
so 50% of all byte values do convert to a negative integer, which results in an EOF Exception in some circumstances
for example if you use the readInt method of DataInputStream
http://docs.oracle.com/javase/7/docs/api/java/io/DataInputStream.html#readInt()
the code looks like this:
the chance is pretty high to get an EOFException...
BTW: it took my a lot of time to find this one. But i do not want to complain :-)
the project is gorgeous, thanks a lot